Author: markt
Date: Tue Feb 16 20:49:18 2010
New Revision: 910683
URL: http://svn.apache.org/viewvc?rev=910683&view=rev
Log:
Withdraw my proposal. Vote for Konstantin's.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=910683&r1=910682&r2=910683&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Feb 16 20:49:18 2010
@@ -182,33 +182,12 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48616
This is a regression caused by the fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=42390
- The requirement for variable declaration also depends on whether or not a
- fragment helper has been used for the parent tag (if any). Where such a
helper
- has been used, the variables must be redefined.
- Test cases for both bugs and the JSP TCK pass with this patch applied.
- http://people.apache.org/~markt/patches/2010-02-14-bug42390.patch
- +1: markt
- -1: kkolinko:
- 1. isImplemetedAsFragment() method is wrong.
- 1) A fragment can also be created with <jsp:attribute> when calling a
tag,
- when the attribute is declared being of type JspFragment.
- -see JSP.5.10 <jsp:attribute>, or the places where the following
method is called:
- Generator#GeneratorVisitor#generateJspFragment(Node, String)
-
- 2) It should navigate up the parents chain. The SimpleTag can be one
- of our parents, not necessary the immediate one.
-
-
- Additional patches (trivial):
- http://svn.apache.org/viewvc?rev=905643&view=rev (misprint)
- http://svn.apache.org/viewvc?rev=909865&view=rev (javadoc)
- +1: kkolinko, markt
- -1:
-
- Alternative proposal:
+ JspFragments are scriptless, so do need to declare or sync scripting
+ variables for fragments. Since errors in syncing the scripting variables for
+ JSP FRagments caused 48616 & 42390, this fixes both these bugs too.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616#c21
(https://issues.apache.org/bugzilla/attachment.cgi?id=24992)
- +1: kkolinko
+ +1: kkolinko, markt
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
