https://issues.apache.org/bugzilla/show_bug.cgi?id=48685
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-02-11 00:07:10 UTC ---
The patch is needs reformatting:
- spaces rather than tabs
- remove the unused imports
- remove System.out
- conform to the existing coding style, particularly placement of {
- remove addition of random blank lines
There also needs to be some explanation/documentation on how this is meant to
work. I assume it only works with an appropriately configured JAAS realm.
Some explanation of how this maps to
http://msdn.microsoft.com/en-us/library/ms995330.aspx and step 5 of "SPNEGO
Token Handshake via HTTP Headers" in particular would also help.
I'm leaning towards the creation of a new authenticator class that extends the
BASIC authenticator and is selected by using SPENGO rather than BASIC in the
web.xml. That would allow per webapp configuration. I also think that, assuming
a fairly specific JAAS configuration is required, that the authenticator should
check that such a configuration is in place and fail to start if it isn't.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
