Author: markt Date: Tue Feb 2 09:57:36 2010 New Revision: 905558 URL: http://svn.apache.org/viewvc?rev=905558&view=rev Log: Tab police so patch will apply cleanly
Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java?rev=905558&r1=905557&r2=905558&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java Tue Feb 2 09:57:36 2010 @@ -38,17 +38,17 @@ */ static class CustomTagCounter extends Node.Visitor { - private int count; - private Node.CustomTag parent; + private int count; + private Node.CustomTag parent; - public void visit(Node.CustomTag n) throws JasperException { - n.setCustomTagParent(parent); - Node.CustomTag tmpParent = parent; - parent = n; - visitBody(n); - parent = tmpParent; - n.setNumCount(new Integer(count++)); - } + public void visit(Node.CustomTag n) throws JasperException { + n.setCustomTagParent(parent); + Node.CustomTag tmpParent = parent; + parent = n; + visitBody(n); + parent = tmpParent; + n.setNumCount(new Integer(count++)); + } } /* @@ -57,92 +57,92 @@ */ static class ScriptingVariableVisitor extends Node.Visitor { - private ErrorDispatcher err; - private Hashtable scriptVars; - - public ScriptingVariableVisitor(ErrorDispatcher err) { - this.err = err; - scriptVars = new Hashtable(); - } - - public void visit(Node.CustomTag n) throws JasperException { - setScriptingVars(n, VariableInfo.AT_BEGIN); - setScriptingVars(n, VariableInfo.NESTED); - new ScriptingVariableVisitor(err).visitBody(n); - setScriptingVars(n, VariableInfo.AT_END); - } - - private void setScriptingVars(Node.CustomTag n, int scope) - throws JasperException { - - TagVariableInfo[] tagVarInfos = n.getTagVariableInfos(); - VariableInfo[] varInfos = n.getVariableInfos(); - if (tagVarInfos.length == 0 && varInfos.length == 0) { - return; - } - - Vector vec = new Vector(); - - Integer ownRange = null; - if (scope == VariableInfo.AT_BEGIN - || scope == VariableInfo.AT_END) { - Node.CustomTag parent = n.getCustomTagParent(); - if (parent == null) - ownRange = MAX_SCOPE; - else - ownRange = parent.getNumCount(); - } else { - // NESTED - ownRange = n.getNumCount(); - } - - if (varInfos.length > 0) { - for (int i=0; i<varInfos.length; i++) { - if (varInfos[i].getScope() != scope - || !varInfos[i].getDeclare()) { - continue; - } - String varName = varInfos[i].getVarName(); - - Integer currentRange = (Integer) scriptVars.get(varName); - if (currentRange == null - || ownRange.compareTo(currentRange) > 0) { - scriptVars.put(varName, ownRange); - vec.add(varInfos[i]); - } - } - } else { - for (int i=0; i<tagVarInfos.length; i++) { - if (tagVarInfos[i].getScope() != scope - || !tagVarInfos[i].getDeclare()) { - continue; - } - String varName = tagVarInfos[i].getNameGiven(); - if (varName == null) { - varName = n.getTagData().getAttributeString( - tagVarInfos[i].getNameFromAttribute()); - if (varName == null) { - err.jspError(n, "jsp.error.scripting.variable.missing_name", - tagVarInfos[i].getNameFromAttribute()); - } - } - - Integer currentRange = (Integer) scriptVars.get(varName); - if (currentRange == null - || ownRange.compareTo(currentRange) > 0) { - scriptVars.put(varName, ownRange); - vec.add(tagVarInfos[i]); - } - } - } + private ErrorDispatcher err; + private Hashtable scriptVars; + + public ScriptingVariableVisitor(ErrorDispatcher err) { + this.err = err; + scriptVars = new Hashtable(); + } + + public void visit(Node.CustomTag n) throws JasperException { + setScriptingVars(n, VariableInfo.AT_BEGIN); + setScriptingVars(n, VariableInfo.NESTED); + new ScriptingVariableVisitor(err).visitBody(n); + setScriptingVars(n, VariableInfo.AT_END); + } + + private void setScriptingVars(Node.CustomTag n, int scope) + throws JasperException { + + TagVariableInfo[] tagVarInfos = n.getTagVariableInfos(); + VariableInfo[] varInfos = n.getVariableInfos(); + if (tagVarInfos.length == 0 && varInfos.length == 0) { + return; + } + + Vector vec = new Vector(); + + Integer ownRange = null; + if (scope == VariableInfo.AT_BEGIN + || scope == VariableInfo.AT_END) { + Node.CustomTag parent = n.getCustomTagParent(); + if (parent == null) + ownRange = MAX_SCOPE; + else + ownRange = parent.getNumCount(); + } else { + // NESTED + ownRange = n.getNumCount(); + } + + if (varInfos.length > 0) { + for (int i=0; i<varInfos.length; i++) { + if (varInfos[i].getScope() != scope + || !varInfos[i].getDeclare()) { + continue; + } + String varName = varInfos[i].getVarName(); + + Integer currentRange = (Integer) scriptVars.get(varName); + if (currentRange == null + || ownRange.compareTo(currentRange) > 0) { + scriptVars.put(varName, ownRange); + vec.add(varInfos[i]); + } + } + } else { + for (int i=0; i<tagVarInfos.length; i++) { + if (tagVarInfos[i].getScope() != scope + || !tagVarInfos[i].getDeclare()) { + continue; + } + String varName = tagVarInfos[i].getNameGiven(); + if (varName == null) { + varName = n.getTagData().getAttributeString( + tagVarInfos[i].getNameFromAttribute()); + if (varName == null) { + err.jspError(n, "jsp.error.scripting.variable.missing_name", + tagVarInfos[i].getNameFromAttribute()); + } + } + + Integer currentRange = (Integer) scriptVars.get(varName); + if (currentRange == null + || ownRange.compareTo(currentRange) > 0) { + scriptVars.put(varName, ownRange); + vec.add(tagVarInfos[i]); + } + } + } - n.setScriptingVars(vec, scope); - } + n.setScriptingVars(vec, scope); + } } public static void set(Node.Nodes page, ErrorDispatcher err) - throws JasperException { - page.visit(new CustomTagCounter()); - page.visit(new ScriptingVariableVisitor(err)); + throws JasperException { + page.visit(new CustomTagCounter()); + page.visit(new ScriptingVariableVisitor(err)); } } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org