On 10/01/2010, [email protected] <[email protected]> wrote:
> Author: markt
> Date: Sun Jan 10 13:11:52 2010
> New Revision: 897635
>
> URL: http://svn.apache.org/viewvc?rev=897635&view=rev
> Log:
> Fix the remaining Eclipse warnings in the non-generated classes
>
> Modified:
> tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java
> tomcat/trunk/java/org/apache/el/parser/AstValue.java
> tomcat/trunk/java/org/apache/el/parser/SimpleNode.java
>
> Modified: tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java?rev=897635&r1=897634&r2=897635&view=diff
>
> ==============================================================================
> --- tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java (original)
> +++ tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java Sun Jan 10
> 13:11:52 2010
> @@ -91,6 +91,7 @@
> ctx.getELResolver().setValue(ctx, null, this.image, value);
> }
>
> + @SuppressWarnings("unchecked")
> @Override
> public Object invoke(EvaluationContext ctx, Class[] paramTypes,
> Object[] paramValues) throws ELException {
> @@ -98,6 +99,7 @@
> }
>
May I suggest that the annotation is applied to the parameter only,
and a comment added as to why it was used?
For example:
@Override
public Object invoke(EvaluationContext ctx,
@SuppressWarnings("unchecked") // Interface uses a raw type
Class[] paramTypes,
Object[] paramValues) throws ELException {
return this.getMethodExpression(ctx).invoke(ctx.getELContext(),
paramValues);
}
I can provide patches if you prefer.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
