On 12/15/2009 02:12 PM, Rainer Jung wrote:

Why is that better?

Uses significant bits out of pthread pointer.

I'm concerned, that it breaks thread id's as logged
by other components. For instance on Solaris I think the thread id
logged by mod_jk is the same as by httpd when using %{tid}P in the
access log

They are logged as 64 bit numbers on 64 bit builds, while our is
casted to the lower 32 bits.


What does the above change result in w.r.t. aligning our thread id with
the one in Apache?


The solution would be to use something like on httpd:
apr_psprintf(r->pool, "%pT", &tid)
which takes care if the pointer is 32/64 and prints it correctly.
Without that stripping upper 32 bits and logging that number makes no
sense whatsoever.

Regards
--
^TM

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to