Author: markt Date: Mon Nov 2 18:48:19 2009 New Revision: 832041 URL: http://svn.apache.org/viewvc?rev=832041&view=rev Log: StringBuffer -> StringBuilder for unit tests
Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java tomcat/trunk/test/org/apache/catalina/tribes/demos/CoordinationDemo.java tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java?rev=832041&r1=832040&r2=832041&view=diff ============================================================================== --- tomcat/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java (original) +++ tomcat/trunk/test/org/apache/catalina/tribes/demos/ChannelCreator.java Mon Nov 2 18:48:19 2009 @@ -53,8 +53,8 @@ public class ChannelCreator { - public static StringBuffer usage() { - StringBuffer buf = new StringBuffer(); + public static StringBuilder usage() { + StringBuilder buf = new StringBuilder(); buf.append("\n\t\t[-bind tcpbindaddress]") .append("\n\t\t[-tcpselto tcpselectortimeout]") .append("\n\t\t[-tcpthreads tcpthreadcount]") Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/CoordinationDemo.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/CoordinationDemo.java?rev=832041&r1=832040&r2=832041&view=diff ============================================================================== --- tomcat/trunk/test/org/apache/catalina/tribes/demos/CoordinationDemo.java (original) +++ tomcat/trunk/test/org/apache/catalina/tribes/demos/CoordinationDemo.java Mon Nov 2 18:48:19 2009 @@ -39,7 +39,7 @@ static int CLEAR_SCREEN = 30; static boolean MULTI_THREAD = false; static boolean[] VIEW_EVENTS = new boolean[255]; - StringBuffer statusLine = new StringBuffer(); + StringBuilder statusLine = new StringBuilder(); Status[] status = null; BufferedReader reader = null; /** @@ -56,7 +56,7 @@ public void clearScreen() { - StringBuffer buf = new StringBuffer(700); + StringBuilder buf = new StringBuilder(700); for (int i=0; i<CLEAR_SCREEN; i++ ) buf.append("\n"); System.out.println(buf); } @@ -90,7 +90,7 @@ //view-id - 24 //view count - 8 - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(leftfill("Member",30," ")); buf.append(leftfill("Running",10," ")); buf.append(leftfill("Coord",30," ")); @@ -240,7 +240,7 @@ } public static String fill(String value, int length, String ch, boolean left) { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if ( !left ) buf.append(value.trim()); for (int i=value.trim().length(); i<length; i++ ) buf.append(ch); if ( left ) buf.append(value.trim()); @@ -266,7 +266,7 @@ //coord - 30 //view-id - 24 //view count - 8 - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); String local = ""; String coord = ""; String viewId = ""; Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java?rev=832041&r1=832040&r2=832041&view=diff ============================================================================== --- tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java (original) +++ tomcat/trunk/test/org/apache/catalina/tribes/demos/IntrospectionUtils.java Mon Nov 2 18:48:19 2009 @@ -466,7 +466,7 @@ if (value.indexOf("$") < 0) { return value; } - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); int prev = 0; // assert value!=nil int pos; @@ -835,7 +835,7 @@ if (log.isDebugEnabled()) { // debug - StringBuffer sb = new StringBuffer(); + StringBuilder sb = new StringBuilder(); sb.append("" + target.getClass().getName() + "." + methodN + "( "); for (int i = 0; i < params.length; i++) { if (i > 0) Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java?rev=832041&r1=832040&r2=832041&view=diff ============================================================================== --- tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java (original) +++ tomcat/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java Mon Nov 2 18:48:19 2009 @@ -221,8 +221,8 @@ public int getRowCount() {return map.sizeFull() +1; } - public StringBuffer getMemberNames(Member[] members){ - StringBuffer buf = new StringBuffer(); + public StringBuilder getMemberNames(Member[] members){ + StringBuilder buf = new StringBuilder(); if ( members!=null ) { for (int i=0;i<members.length; i++ ) { buf.append(members[i].getName()); @@ -350,17 +350,17 @@ System.out.println(e.getActionCommand()); if ( "add".equals(e.getActionCommand()) ) { System.out.println("Add key:"+txtAddKey.getText()+" value:"+txtAddValue.getText()); - map.put(txtAddKey.getText(),new StringBuffer(txtAddValue.getText())); + map.put(txtAddKey.getText(),new StringBuilder(txtAddValue.getText())); } if ( "change".equals(e.getActionCommand()) ) { System.out.println("Change key:"+txtChangeKey.getText()+" value:"+txtChangeValue.getText()); - StringBuffer buf = (StringBuffer)map.get(txtChangeKey.getText()); + StringBuilder buf = (StringBuilder)map.get(txtChangeKey.getText()); if ( buf!=null ) { buf.delete(0,buf.length()); buf.append(txtChangeValue.getText()); map.replicate(txtChangeKey.getText(),true); } else { - buf = new StringBuffer(); + buf = new StringBuilder(); buf.append(txtChangeValue.getText()); map.put(txtChangeKey.getText(),buf); } @@ -378,7 +378,7 @@ public void run() { for (int i = 0; i < 5; i++) { String key = random(5,0,0,true,true,null); - map.put(key, new StringBuffer(key)); + map.put(key, new StringBuilder(key)); dataModel.fireTableDataChanged(); table.paint(table.getGraphics()); try { Modified: tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java?rev=832041&r1=832040&r2=832041&view=diff ============================================================================== --- tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java (original) +++ tomcat/trunk/test/org/apache/catalina/valves/Benchmarks.java Mon Nov 2 18:48:19 2009 @@ -206,12 +206,12 @@ } public String printDate() { - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); Date date = getDateSync(); if (currentDate != date) { synchronized (this) { if (currentDate != date) { - StringBuffer current = new StringBuffer(32); + StringBuilder current = new StringBuilder(32); current.append('['); current.append(dayFormatter.format(date)); // Day current.append('/'); @@ -285,7 +285,7 @@ public String printDate() { getDateLocal(); if (currentDateStringLocal.get() == null) { - StringBuffer current = new StringBuffer(32); + StringBuilder current = new StringBuilder(32); current.append('['); current.append(dayFormatterLocal.get().format( currentDateLocal.get())); // Day @@ -345,7 +345,7 @@ getDateLocal(); Struct struct = structLocal.get(); if (struct.currentDateString == null) { - StringBuffer current = new StringBuffer(32); + StringBuilder current = new StringBuilder(32); current.append('['); current.append(struct.dayFormatter.format(struct.currentDate)); // Day current.append('/'); --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org