Author: kkolinko
Date: Fri Oct 30 04:49:35 2009
New Revision: 831201
URL: http://svn.apache.org/viewvc?rev=831201&view=rev
Log:
vote
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831201&r1=831200&r2=831201&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Oct 30 04:49:35 2009
@@ -215,6 +215,7 @@
http://people.apache.org/~markt/patches/2009-08-15-AccessLogValve-tc6.patch
+1: markt, kkolinko
-1:
+
kkolinko: Also +1 to use StringBuilder everywhere in those classes, with
exception of those places where it is passed as the argument to
AccessLogValve.AccessLogElement#addElement().
@@ -309,6 +310,7 @@
that file (because part of a webapp), but maybe it would
be cleaner to do this for the installer target only, e.g.
saving the file, fixcrlf, run nsi, restoring file.
+
kkolinko: Another way to fix it would be to place a copy of that file
into %CATALINA_HOME% (with proper CRLF endings) and display that one in
the installer, leaving the one in the ROOT webapp as is. Note, that we
@@ -356,5 +358,5 @@
* Use correct flag for SSL
http://svn.apache.org/viewvc?rev=831106&view=rev
- +1: fhanik
+ +1: fhanik, kkolinko
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
