Author: fhanik Date: Mon Sep 14 15:43:41 2009 New Revision: 814708 URL: http://svn.apache.org/viewvc?rev=814708&view=rev Log: Allow buffer size to be configurable instead of accepting the default
Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java tomcat/trunk/webapps/docs/logging.xml Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/FileHandler.java?rev=814708&r1=814707&r2=814708&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/juli/FileHandler.java (original) +++ tomcat/trunk/java/org/apache/juli/FileHandler.java Mon Sep 14 15:43:41 2009 @@ -96,6 +96,11 @@ * The PrintWriter to which we are currently logging, if any. */ private PrintWriter writer = null; + + /** + * Log buffer size + */ + private int bufferSize = 8192; // --------------------------------------------------------- Public Methods @@ -212,7 +217,12 @@ prefix = getProperty(className + ".prefix", "juli."); if (suffix == null) suffix = getProperty(className + ".suffix", ".log"); - + String sBufferSize = getProperty(className + ".bufferSize", "8192"); + try { + bufferSize = Integer.parseInt(sBufferSize); + } catch (NumberFormatException ignore) { + //no op + } // Get encoding for the logging file String encoding = getProperty(className + ".encoding", null); if (encoding != null && encoding.length() > 0) { @@ -284,7 +294,7 @@ prefix + date + suffix; String encoding = getEncoding(); OutputStream os = new BufferedOutputStream(new FileOutputStream( - pathname, true)); + pathname, true),bufferSize); writer = new PrintWriter( (encoding != null) ? new OutputStreamWriter(os, encoding) : new OutputStreamWriter(os), true); Modified: tomcat/trunk/webapps/docs/logging.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/logging.xml?rev=814708&r1=814707&r2=814708&view=diff ============================================================================== --- tomcat/trunk/webapps/docs/logging.xml (original) +++ tomcat/trunk/webapps/docs/logging.xml Mon Sep 14 15:43:41 2009 @@ -128,6 +128,8 @@ boolean value.</li> <li>The root logger can define its set of handlers using a <code>.handlers</code> property.</li> + <li>Logging is buffered using a default buffer size of 8192 bytes. + To change buffersize, use the <code>bufferSize</code> property.</li> <li>System property replacement for property values which start with ${systemPropertyName}.</li> </ul> @@ -163,6 +165,7 @@ 4admin.org.apache.juli.FileHandler.level = FINE 4admin.org.apache.juli.FileHandler.directory = ${catalina.base}/logs 4admin.org.apache.juli.FileHandler.prefix = admin. +4admin.org.apache.juli.FileHandler.bufferSize = 16384 java.util.logging.ConsoleHandler.level = FINE java.util.logging.ConsoleHandler.formatter = java.util.logging.SimpleFormatter --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org