Author: rjung
Date: Tue Sep  1 18:40:32 2009
New Revision: 810161

URL: http://svn.apache.org/viewvc?rev=810161&view=rev
Log:
Vote.

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=810161&r1=810160&r2=810161&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Sep  1 18:40:32 2009
@@ -174,7 +174,7 @@
 
 * Fix NPE observed when unpackWARs="false" with above fix
   http://svn.apache.org/viewvc?view=rev&revision=805153
-  +1: markt, funkman
+  +1: markt, funkman, rjung
   -1: 
 
 * Port Active Directory improvements to JNDIREalm from trunk
@@ -237,14 +237,17 @@
 * Expose filter configuration via JMX (read-only)
   Based on a patch by Xie Xiaodong as part of GSOC2009.
   http://svn.apache.org/viewvc?rev=802727&view=rev
-  +1: markt, funkman
+  +1: markt, funkman, rjung
   -1: 
+  rjung: typo regsiter -> register should be corrected everywhere (method name,
+         log messages etc., string manager property, sometimes with 
capitalzation "Regsiter")
+         Another little style nitpick: "if(" -> "if (".
 
 * Use platform MBean server rather than creating a new one. Makes it possible 
to
   connect JConsole and other JMX tools to locally running Tomcat instances
   without any config changes to Tomcat
   http://svn.apache.org/viewvc?rev=677910&view=rev 
-  +1: markt, funkman
+  +1: markt, funkman, rjung
   -1: 
 
 * Add remote JMX listener. Enables JMX to be configured so that it can be used
@@ -252,8 +255,12 @@
   uses one fixed and one random port.
   Needs the platform MBean server fix above to be really useful
   http://people.apache.org/~markt/patches/2009-08-12-jmx-remote.patch
-  +1: markt, funkman
+  +1: markt, funkman, rjung
   -1: 
+  rjung: The docs page contains a typo: rmiRegsitryPortPlatform -> 
rmiRegistryPortPlatform
+         There are also some hidden defaults (password and access file) which 
might make
+         sense to be added to the docs. Directory for those default files is
+         CATALINA_BASE and not CATALINA_BASE/conf?
 
 * Make context deployment error message more meaningful
   http://svn.apache.org/viewvc?rev=802940&view=rev
@@ -264,7 +271,7 @@
   https://issues.apache.org/bugzilla/show_bug.cgi?id=47046
   Clean up Jk components that only exist in the 6.0.x and were hence missed
   https://issues.apache.org/bugzilla/attachment.cgi?id=24125
-  +1: markt, funkman
+  +1: markt, funkman, rjung
   -1: 
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45403
@@ -318,7 +325,7 @@
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47705
   ArithmeticException: / by zero when expiring sessions via manager 
   http://svn.apache.org/viewvc?rev=809603&view=rev
-  +1: funkman
+  +1: funkman, rjung
   -1:
 
 
@@ -339,7 +346,5 @@
              }
          }
 
-  +1: fhanik
+  +1: fhanik, rjung
   -1: 
-
-



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to