https://issues.apache.org/bugzilla/show_bug.cgi?id=47612
Summary: [PATCH] fix unsafe public string array in AbstractCreateStatementInterceptor Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Modules: jdbc-pool AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=24070) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24070) Protect array against changes; remove "magic" numbers As previously mentioned on the Tomcat-dev list, the AbstractCreateStatementInterceptor class has two public static String arrays. These can easily be changed accidentally or deliberately. There subclasses which use the arrays also depend on the order of the entries in the arrays. The patch makes the arrays private, and makes the array order explicit, eliminating the "magic" numbers currently used to access the array entries. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org