Author: kkolinko
Date: Thu Jul 16 13:35:17 2009
New Revision: 794668

URL: http://svn.apache.org/viewvc?rev=794668&view=rev
Log:
veto

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=794668&r1=794667&r2=794668&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jul 16 13:35:17 2009
@@ -112,7 +112,11 @@
   Update AccessLogValve with all the recent threading improvements
   http://people.apache.org/~markt/patches/2009-06-24-AccessLogValve-tc6.patch
   +1: markt
-  -1: 
+  -1: kkolinko: It cannot be applied without additional patches,
+    because this change breaks ExtendedAccessLogValve.DateElement and
+    TimeElement: Their "if (currentDate != date)" check is broken,
+    because now the Date instance is reused in the same thread, and is
+    different across threads.
 
 * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
   Reverts previous fix for



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to