Author: markt
Date: Sun Jul 12 16:32:25 2009
New Revision: 793374
URL: http://svn.apache.org/viewvc?rev=793374&view=rev
Log:
Propose new patch for
Modified:
tomcat/current/tc5.5.x/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=793374&r1=793373&r2=793374&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 12 16:32:25 2009
@@ -33,46 +33,10 @@
0: fhanik - big step for an old branch, could be risky, I'd wait until
after next release if we consider it
-1:
-* Various script improvements (free free to vote for them individually)
- http://svn.apache.org/viewvc?rev=791331&view=rev (align platforms / bug
39194)
- +1: markt, rjung
- -1: kkolinko
- It introduces the "javac" optional command, that was not there before.
- (The "javac" command was not documented, and I think it was not working
- at all, because of missing "shift" command.
- It was introduced in http://svn.apache.org/viewvc?view=rev&revision=303625
- )
- How this "javac" is supposed to be used? One has to modify
- startup.[sh|bat] and shutdown.[sh|bat]?
- We switch between JDK and JRE based on env.variables (e.g. introduced
- through setenv.[sh|bat]). Why not to add tools.jar always when JDK is
- used?
- rjung: It looks to me like "javac" as an argument was possible before the
patch
- (even already in tc4.1) but wasn't actually changing anything except for
- additional checks. A _RUNJAVAC was set but never used.
- After the patch javac is meant to do something, namely adding tools.jar to
- the classpath. The shift seems to be in
-
http://svn.apache.org/viewvc/tomcat/trunk/bin/setclasspath.sh?r1=791331&r2=791330&pathrev=791331
- I don't like adding tools.jar whenever a JDK is used. The JDK contains
additional
- tools relative to the JRE, so I always prefer people to install the JDK
even
- when they only use the JDT compiler for Tomcat.
- kkolinko:
- It isn't there in 4.1
-
http://svn.apache.org/repos/asf/tomcat/archive/tc4.1.x/trunk/container/catalina/src/bin/
- > The shift seems to be in ...
- Yes, that is the shift I am referring to. It is a part of the proposed
- patch. It isn't there in the current 5.5 and 6.0 *.sh files.
- > I don't like adding tools.jar whenever a JDK is used.
- OK, I understand this.
- My position is that to add or not to add tools.jar is a configuration
- choice. Thus it is better to have it controllable via setenv.sh
- (well, even now one can set CLASSPATH there, or add tools.jar to
- common.loader of catalina.properties - haven't tried the latter)
- Though we already have a switch that controlls configuration: "-security".
- markt:
- How about an alternative approach that removes the javac command completely
- rather than trying to fix it? As has been pointed out, setenv can be used
to
- achieve the same end and is more consistent with how we do things now,
+* Script improvement - alternative patch
+ http://svn.apache.org/viewvc?rev=793372&view=rev (align platforms / bug
39194)
+ +1: markt
+ -1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39231
http://svn.apache.org/viewvc?rev=791900&view=rev
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=793374&r1=793373&r2=793374&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 12 16:32:25 2009
@@ -132,10 +132,10 @@
+1: markt, kkolinko
-1:
-* Script improvement
- http://svn.apache.org/viewvc?rev=791331&view=rev (align platforms / bug
39194)
- +1: markt, rjung
- -1: kkolinko: See tc5.5 status file for discussion.
+* Script improvement - alternative patch
+ http://svn.apache.org/viewvc?rev=793372&view=rev (align platforms / bug
39194)
+ +1: markt
+ -1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47478
https://svn.apache.org/viewcvs.cgi?view=rev&rev=791524
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
