Author: kkolinko
Date: Tue Jul 7 03:29:14 2009
New Revision: 791690
URL: http://svn.apache.org/viewvc?rev=791690&view=rev
Log:
vote
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791690&r1=791689&r2=791690&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Tue Jul 7 03:29:14 2009
@@ -126,3 +126,17 @@
http://svn.apache.org/viewvc?rev=791331&view=rev (align platforms / bug
39194)
+1: markt, rjung (all three patches)
-1:
+ kkolinko:
+ +1 for the first and second patches (791326, 791328)
+ -1 for the third patch
+ I do not like the third patch:
+ It introduces the "javac" optional command, that was not there before.
+ (The "javac" command was not documented, and I think it was not working
+ at all, because of missing "shift" command.
+ It was introduced in http://svn.apache.org/viewvc?view=rev&revision=303625
+ )
+ How this "javac" is supposed to be used? One has to modify
+ startup.[sh|bat] and shutdown.[sh|bat]?
+ We switch between JDK and JRE based on env.variables (e.g. introduced
+ through setenv.[sh|bat]). Why not to add tools.jar always when JDK is
+ used?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
