Author: fhanik
Date: Tue Jun 23 15:09:51 2009
New Revision: 787699
URL: http://svn.apache.org/viewvc?rev=787699&view=rev
Log:
Adjust patch to 6.0, remove previous votes. NIO in 6.0 still has synchronized
based thread pool
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=787699&r1=787698&r2=787699&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Jun 23 15:09:51 2009
@@ -161,37 +161,8 @@
* Dont try to report thread counts when using an executor from outside
http://people.apache.org/~fhanik/connector-thread-report.patch
- +1: fhanik, markt
+ +1: fhanik
-1:
- -1: kkolinko: (
- 1. Why such short implementation for JIoEndpoint, AprEndpoint and
- such elaborated one for NioEndpoint?
-fhanik: NioEndpoint only uses Executors, it's removed the 'synchronized' based
thread pool.
-kkolinko: Thanks for explaining, but for 6.0 code that is not true:
- The NioEndpoint.getWorkerThread() method does exist in 6.0,
- so your patch will break the thing, thus my -1.
- I do not know whether it is actually used. Maybe you can remove
- workers support from 6.0.
-
- There could be "return curThreads[Busy];" instead of "return -2;" in
your patch.
-
-
- Is there a reason why JIoEndpoint, AprEndpoint are not
- implemented in the same way?
-fhanik: there was a notion that the Tomcat thread pool was faster, hence the
old one is still there
-kkolinko: I mean: why not to ask ThreadPoolExecutor for the values,
- like the NioEndpoint part of the patch does?
-
-
- 2. Http11Processor calls JIoEndpoint.getCurrentThreadsBusy():
-
- int threadRatio = (endpoint.getCurrentThreadsBusy() * 100)
- / endpoint.getMaxThreads();
-
- The threadRatio value will be negative, if the patch is applied as
- is. Well, that makes no much difference from zero value w/o the patch.
-fhanik: That is a great point, This is an important observations that warrants
another patch, independent of this one
- )
* Fix download task dependency for commons-pool and commons-dbcp.
http://svn.apache.org/viewvc?rev=783762&view=rev
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
