Filip Hanik - Dev Lists wrote: > Mark Thomas wrote: >> Filip Hanik - Dev Lists wrote: >> >>> we're copying bytes to two new byte arrays on every call, just so that >>> we have info when it fails? >>> >> >> For query string there is (and always has been) one copy and then this >> patch copies again for the failure info. >> >> For POST requests the only copy is for the failure info. >> >> >>> especially only logged with debugEnabled, shouldn't your logic check >>> that flag then >>> >> >> The debug logging includes the exception. There is still warn level >> logging that provides the information on the failed parameters. >> >> One option to reduce the copying would be to log the failure with the >> corrupted data at warn level along with the info that if you use debug >> logging you'll see the original data. That would move the copying to >> debug only although you might see some odd messages depending on how the >> decoding failed. >> >> What do you think? >> > That sounds good to me. One could adjust the warn message to let the > user know that more info is available during debug.
That was the idea. I'll fix trunk and then re-propose the 6.0.x change as a single patch so it is easier to review. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
