Author: kkolinko
Date: Wed Jun 17 21:05:49 2009
New Revision: 785803
URL: http://svn.apache.org/viewvc?rev=785803&view=rev
Log:
vote, comment
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=785803&r1=785802&r2=785803&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Jun 17 21:05:49 2009
@@ -163,6 +163,22 @@
http://people.apache.org/~fhanik/connector-thread-report.patch
+1: fhanik, markt
-1:
+ +1: kkolinko: (
+ good, but
+ 1. Why such short implementation for JIoEndpoint, AprEndpoint and
+ such elaborated one for NioEndpoint?
+
+ Is there a reason why JIoEndpoint, AprEndpoint are not
+ implemented in the same way?
+
+ 2. Http11Processor calls JIoEndpoint.getCurrentThreadsBusy():
+
+ int threadRatio = (endpoint.getCurrentThreadsBusy() * 100)
+ / endpoint.getMaxThreads();
+
+ The threadRatio value will be negative, if the patch is applied as
+ is. Well, that makes no much difference from zero value w/o the patch.
+ )
* Fix download task dependency for commons-pool and commons-dbcp.
http://svn.apache.org/viewvc?rev=783762&view=rev
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
