Author: kkolinko
Date: Sat Jun 6 23:26:49 2009
New Revision: 782320
URL: http://svn.apache.org/viewvc?rev=782320&view=rev
Log:
propose updated patch
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=782320&r1=782319&r2=782320&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Sat Jun 6 23:26:49 2009
@@ -49,12 +49,11 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38483
Make access log valves thread safe (part 2)
- (It is an addition to markts' 2009-02-04-bug38483.patch that is proposed
above)
+ (It is an addition to markt's 2009-02-04-bug38483.patch that is proposed
above)
The dateFormatter that is used for log file rotation also needs its syncs.
- The sync block scope is wide, because rotationLastChecked assignment is also
- not safe: long and pointer assignments are not atomic.
- It also allows us to get rid of double checks for tsDate.
- http://people.apache.org/~kkolinko/patches/2009-05-29_bug38483_2.patch
+ Also added volatile modifier to rotationLastChecked, because
+ long assignments are not atomic. (see Java Language Specification 3rd ed,
ch. 17.7)
+ http://people.apache.org/~kkolinko/patches/2009-06-07_bug38483_2.patch
+1: kkolinko
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
