On 07/04/2009, Remy Maucherat <r...@apache.org> wrote:
> The candidates binaries are available here:
>  http://people.apache.org/~remm/tomcat-6/v6.0.19/

Hashes and sigs look OK, though I only checked the main archives.

There's a packaging problem with the source archives.

I would expect the .zip and .tar.gz to have the same contents, apart
possibly from line endings. However there are other differences which
appear to be caused by character set problems. E.g. in

LocalStrings_de.properties - zip
htmlManagerServlet.appsAvailable=Verfügbar

whereas in

LocalStrings_de.properties - tar.gz
htmlManagerServlet.appsAvailable=Verf�gbar

[In case this does not make it unscathed through the mail system, the
first one shows up as u-umlaut and the second as a small square.]

The underlying bytes are:

u-umlaut = FC
blob = EF BF BD

This problem affects many properties files, also changelog.xml and KEYS.

Furthermore, some of the binary files are different, for example
requestProcess.pdf and serverStartup.pdf. The tar.gz versions of the
PDFs don't seem to be usable.

The tomcat exes are also different. Perhaps no-one will use .tar.gz on
Windows, but that's not impossible.

Clearly the process for creating the source tar.gz archives is not
working properly.

The binary zip archive contains two extra (empty) directories, work
and log, but otherwise the contents match, so they seem OK.

The NOTICE files say:
Copyright 1999-2007 The Apache Software Foundation

Unless the software has not been significantly updated since 2007,
that needs to be changed.

Findbugs also says that there are lots of problems with the code.
Some of them look quite serious, e.g. synchronising on an object
reference that the code then replaces with another object. I can
upload the analysis if required.

>  According to the release process, the 6.0.19 tag is:
>  [X] Broken
>  [ ] Alpha
>  [ ] Beta
>  [ ] Stable
>
>  Note: The i18n issue for the French language could be addressed by
>  providing a replacement JAR from a bugzilla, since I suppose the
>  affected user base is not that large.
>
>  Rémy
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>  For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to