Since it's a new variable, one can make it private now without breaking anything.
Every little helps. On 23/03/2009, Filip Hanik - Dev Lists <devli...@hanik.com> wrote: > one could also make a toilet made out of solid gold, but it's just not in > the cards now is it? > http://www.imdb.com/character/ch0002425/quotes > > > > > sebb wrote: > > > On 23/03/2009, fha...@apache.org <fha...@apache.org> wrote: > > > > > > > Author: fhanik > > > Date: Mon Mar 23 12:07:36 2009 > > > New Revision: 757381 > > > > > > URL: http://svn.apache.org/viewvc?rev=757381&view=rev > > > Log: > > > expose the poolname through a public method, this will allow one to > retrieve the actual connection pool through JMX as well > > > > > > Modified: > > > > tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java > > > > > > Modified: > tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java > > > URL: > http://svn.apache.org/viewvc/tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java?rev=757381&r1=757380&r2=757381&view=diff > > > > ============================================================================== > > > --- > tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java > (original) > > > +++ > tomcat/trunk/modules/jdbc-pool/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java > Mon Mar 23 12:07:36 2009 > > > @@ -44,10 +44,6 @@ > > > > > > protected volatile ConnectionPool pool = null; > > > > > > > > > > > > > Since getPool() is public, one could make the variable private. > > > > > > > > > - public ConnectionPool getPool() { > > > - return pool; > > > - } > > > - > > > protected PoolProperties poolProperties = new PoolProperties(); > > > > > > public DataSourceProxy() { > > > @@ -125,6 +121,14 @@ > > > String password) throws > SQLException { > > > return (PooledConnection) getConnection(); > > > } > > > + > > > + public ConnectionPool getPool() { > > > + return pool; > > > + } > > > + > > > + public String getPoolName() { > > > + return pool.getName(); > > > + } > > > > > > /** > > > * {...@inheritdoc} > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: > dev-unsubscr...@tomcat.apache.org > > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
