Hi Mladen,
On 22.03.2009 10:19, Mladen Turk wrote:
Rainer Jung wrote:
On 21.03.2009 14:12, Mladen Turk wrote:
I just committed a change to TC trunk and backport proposals to pick
up the REMOTE_PORT env var for request.getRemotePort().
So we might think about forwarding REMOTE_PORT by default in JK 1.2.29.
See the note I added to 6.0 STATUS.
IMO we should prefix all those env vars either with AJP_ or like
you did already for some with JK_
Now, JK_ is fine, but the AJP_ is more intuitive because it
can be reused by mod_proxy_ajp as well.
Not sure, but those vars on Tomcat side should be
removed when processed so that they don't end up
in req attributes since they are protocol private,
and if the AJP protocol would support this they would
never be visible.
You are right.
We can use a private request attribute name like AJP_REMOTE_PORT. What
would the value of the attribute be? It would be the port directly taken
from the web server connection object (Apache and as far as possible
also IIS).
For Apache we would also provide a default environment variable
JK_REMOTE_PORT which allows the web server admin to overwrite the port
and a directive JkRemotePortIndicator to choose a different environment
to look up for an overwrite (like setting JkRemoteIndicator to
REMOTE_PORT). This part would be exactly the same as we allow to handle
it for all other metadata since 1.2.28.
Good point. I will correct the trunk patch for Tomcat and the backport
proposals. Let's see, what others say.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
