Author: markt Date: Sat Feb 21 12:00:00 2009 New Revision: 746487 URL: http://svn.apache.org/viewvc?rev=746487&view=rev Log: Remove unused code. Deprecate NOOP method
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java?rev=746487&r1=746486&r2=746487&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11AprProtocol.java Sat Feb 21 12:00:00 2009 @@ -32,7 +32,6 @@ import javax.management.ObjectName; import org.apache.coyote.ActionCode; -import org.apache.coyote.ActionHook; import org.apache.coyote.Adapter; import org.apache.coyote.ProtocolHandler; import org.apache.coyote.RequestGroupInfo; @@ -567,9 +566,7 @@ processor = createProcessor(); } - if (processor instanceof ActionHook) { - ((ActionHook) processor).action(ActionCode.ACTION_START, null); - } + processor.action(ActionCode.ACTION_START, null); SocketState state = processor.process(socket); if (state == SocketState.LONG) { Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java?rev=746487&r1=746486&r2=746487&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11NioProtocol.java Sat Feb 21 12:00:00 2009 @@ -31,7 +31,6 @@ import javax.management.ObjectName; import org.apache.coyote.ActionCode; -import org.apache.coyote.ActionHook; import org.apache.coyote.Adapter; import org.apache.coyote.ProtocolHandler; import org.apache.coyote.RequestGroupInfo; @@ -262,6 +261,11 @@ ep.setExecutor(executor); } + /** + * NOOP. + * @param useexec - Ignored + * @deprecated Executors are always used for NIO + */ public void setUseExecutor(boolean useexec) { ep.setUseExecutor(useexec); } @@ -733,10 +737,7 @@ processor = createProcessor(); } - if (processor instanceof ActionHook) { - ((ActionHook) processor).action(ActionCode.ACTION_START, null); - } - + processor.action(ActionCode.ACTION_START, null); if (proto.ep.getSecure() && (proto.sslImplementation != null)) { if (socket instanceof SecureNioChannel) { Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java?rev=746487&r1=746486&r2=746487&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java (original) +++ tomcat/trunk/java/org/apache/coyote/http11/Http11Protocol.java Sat Feb 21 12:00:00 2009 @@ -32,7 +32,6 @@ import javax.management.ObjectName; import org.apache.coyote.ActionCode; -import org.apache.coyote.ActionHook; import org.apache.coyote.Adapter; import org.apache.coyote.ProtocolHandler; import org.apache.coyote.RequestGroupInfo; @@ -573,9 +572,7 @@ processor = createProcessor(); } - if (processor instanceof ActionHook) { - ((ActionHook) processor).action(ActionCode.ACTION_START, null); - } + processor.action(ActionCode.ACTION_START, null); if (proto.secure && (proto.sslImplementation != null)) { processor.setSSLSupport @@ -611,9 +608,7 @@ // if(proto.adapter != null) proto.adapter.recycle(); // processor.recycle(); - if (processor instanceof ActionHook) { - ((ActionHook) processor).action(ActionCode.ACTION_STOP, null); - } + processor.action(ActionCode.ACTION_STOP, null); recycledProcessors.offer(processor); } return false; --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org