While cleaning up sounds tempting, it's been tried before.
I'd rather not do it, just for the sake of cleanup. The connectors have
way too many edge cases to work around, and they are fairly easy to break.
There are plenty of new features to add in for servlet 3.0, and cleanup
will most likely only destabilize and introduce new bugs, with nothing
or little gained
Filip
Peter Rossbach wrote:
Hi,
a common connector code base is possible. A lot of duplication exists
at current tomcat 6.x handlers implementations.
We must also look at AjpProtocol and AjpAprProtocol classes.
Why we don't use the internal executor at all handlers?
Why internal executor as no JMX MBean representation?
Why processor caches are can't shrinking ?
The Connector/Handler/xx dynamic property binding is strange. Why
ProtocolHandler, Executor and Endpoint are not subelements from
connector tag at server.xml?
I think the usage of a common base are a design shift and a good
feature to start at tomcat 7:-).
Regards
Peter
Am 23.11.2008 um 10:19 schrieb Mark Thomas:
Filip Hanik - Dev Lists wrote:
No, you're not missing anything.
NIO can use a shared executor, and internal executor or the thread pool
based on synchronized/wait/notify
For the sake of consistency in configuration, is there any merit in
deprecating the use of the internal executor or alternatively, adding an
internal executor option to the other connectors?
On a related topic reducing the duplication of code between the
connectors
is on my wish list for my current code clean up but I haven't looked
at it
yet. My initial thoughts are around the use of some common base classes.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
