On 19/11/2008, Mark Thomas <[EMAIL PROTECTED]> wrote: > The source tarball and other packages are available here: > http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.39/
Hashes and sigs all work OK now. However there are some problems with the archives. == There are two copies of the source, in zip and tar.gz format. I would expect the contents to be the same, apart from line-endings in source files. However, there are several binary files that are different: connectors/jni/native/os/win32/logmessages.bin connectors/procrun/bin.../tomcat*.exe This suggests a packaging error - perhaps these bin files were incorrectly formatted to correct the line-endings? Also, the procrun/README.txt file refers to Tomcat 5 (trivial) There are no top-level LICENSE and NOTICE files in the archive; instead there are various different files at different levels of the directory tree. Not every LICENSE file has an accompanying NOTICE file. == The binary zip archive has several empty directories that are not in the tgz version: logs shared work common/classes common/classes Is this intentional? The binary archives have one copy each of tomcat4.exe and tomcat4w.exe; I presume this is the version for Intel 32 bit. Why not include the amd64 and ia64 versions as well? The NOTICE and LICENSE files in the binary archive refer to several products that don't seem to be included (at least not as separate jars) JSSE JUnit pureTLS Tyrex === Findbugs reports lots of bugs, but I don't know if they relate to code that is actually used or not. For example, the org.apache.tomcat.util.threads.Reaper class uses a boolean field "running" to communicate with a different thread, but fails to synchronize access and does not use volatile. > According to the release process, the 4.1.39 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [ ] Stable > > Cheers, > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
