* Allow huge request body packets for AJP13.
This was already applied to connectors, but never
@@ -167,32 +171,34 @@
http://svn.apache.org/viewvc?rev=697192&view=rev
Original change: http://svn.apache.org/viewvc?rev=486217&view=rev
+1: rjung, mturk, markt
- -1:
+ -1: remm (- bodyMsg.appendInt(AjpConstants.MAX_READ_SIZE + packetSize - AjpConstants.MAX_PACKET_SIZE); looks wrong
Before the change it was simply MAX_READ_SIZE. After the change, if our
actual configured maximum packet size (A=packetSize) is bigger or
smaller than the default one (B=MAX_PACKET_SIZE) we adjust the read size
accordingly by the delta A-B.
Phrased diffferentyl:
MAX_READ_SIZE = MAX_PACKET_SIZE - H_SIZE - 2;
So
MAX_READ_SIZE + packetSize - MAX_PACKET_SIZE =
MAX_PACKET_SIZE - H_SIZE - 2 + packetSize - MAX_PACKET_SIZE =
packetSize -H_SIZE - 2
In your code there is packetSize <=> MAX_PACKET_SIZE. I had
MAX_READ_SIZE = MAX_PACKET_SIZE - whatever_the_header_length_is, so I
don't see how it should not become MAX_READ_SIZE <=> packetSize -
whatever_the_header_length_is.
Sorry Rémy, I don't understand you. packetSize is always >=
MAX_PACKET_SIZE and MAX_PACKET_SIZE is fixed at 8192.
The above formula is equivalent to
packetSize - whatever_the_header_length_is
which itself is >= MAX_PACKET_SIZE - whatever_the_header_length_is.
That sounds strange, but as I mentioned, MAX_PACKET_SIZE is no longer
the maximum. It is the default maximum, which can be increased by
configuration.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
