Rainer Jung wrote:
Hi Mladen,

any thoughts, how we could make configuring connection_keepalive better?

Of course by introducing even more attributes we can keep the individual
CPING timeouts, but I don't really see a reason. I want to get the
attributes right, before we release this nice feature.

Comments?


We must not change the existing behavior nor directives.
They are widely used, so IMO, we can only use the
additional directive (probe_timeout is fine),
although ping_timeout is more intuitive.

We can then use that ping_timeout for connect_timeout
if the connect_timeout value is boolean (allowing booleans first)
The same for prepost_timeout.

so.
worker.x.ping_timeout=NNN
worker.x.connect_timeout=True|On|1 (will set to ping_timeout)
worker.x.prepost_timeout=True|On|1 (will set to ping_timeout)

If you like we could use one additional
worker.x.ping_mode=connect,prepost,keepalive
I'd like we use single letters here 'CPK'

Also I don't like we deprecate *_timeout directives.

Next,
connection_keepalive should probably get
renamed to connection_keepalive_interval


Cheers
--
^(TM)

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to