Author: markt Date: Wed Aug 13 15:35:33 2008 New Revision: 685712 URL: http://svn.apache.org/viewvc?rev=685712&view=rev Log: Fix 45591. NPE on start-up failure in some cases. Based on a patch by Matt Passell
Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/java/org/apache/jk/server/JkMain.java tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Aug 13 15:35:33 2008 @@ -1 +1 @@ -/tomcat/trunk:673796,673820 +/tomcat/trunk:673796,673820,683982 Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=685712&r1=685711&r2=685712&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Wed Aug 13 15:35:33 2008 @@ -71,12 +71,6 @@ 0: remm (looks risky, very minor problem) -1: -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45591 - NPE on start-up failure in some cases. Based on a patch by Matt Passell - http://svn.apache.org/viewvc?rev=683982&view=rev - +1: markt, remm, funkman - -1: - * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45585 Tomcat failed to start if using $CATALINA_BASE but not JULI. Patch based on a suggestion by Ian Ward Comfort Modified: tomcat/tc6.0.x/trunk/java/org/apache/jk/server/JkMain.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/jk/server/JkMain.java?rev=685712&r1=685711&r2=685712&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/java/org/apache/jk/server/JkMain.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/jk/server/JkMain.java Wed Aug 13 15:35:33 2008 @@ -676,9 +676,12 @@ } public void pause() throws Exception { - for( int i=0; i<wEnv.getHandlerCount(); i++ ) { - if( wEnv.getHandler(i) != null ) { - wEnv.getHandler(i).pause(); + // wEnv sometime null at shutdown - bug45591 + if (wEnv != null) { + for( int i=0; i<wEnv.getHandlerCount(); i++ ) { + if( wEnv.getHandler(i) != null ) { + wEnv.getHandler(i).pause(); + } } } } Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=685712&r1=685711&r2=685712&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Wed Aug 13 15:35:33 2008 @@ -39,6 +39,14 @@ <bug>45453</bug>: Remove potential race condition in JDBC Realm. Based on a patch by Santtu Hyrkk. (markt) </fix> + </changelog> + </subsection> + <subsection name="Coyote"> + <changelog> + <fix> + <bug>45591</bug>: NPE on start-up failure in some cases. Based on a + patch by Matt Passell. (markt) + </fix> </changelog> </subsection> <subsection name="Jasper"> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]