Re: svn commit: r656124 - /tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java

[Peter Rossbach]

Hi Mark

Java 5 don't support new IOExceptin(String, Throwable)
compile:
    [javac] Compiling 49 source files to /Users/peter/develop/ 
projects/tomcat/tomcat6currenttrunk/output/classes
    [javac] /Users/peter/develop/projects/tomcat/tomcat6currenttrunk/ 
java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java:335:  
cannot find symbol
    [javac] symbol  : constructor IOException 
(java.lang.String,java.lang.Exception)
    [javac] location: class java.io.IOException
    [javac]             throw new IOException(msg, ex);
    [javac]                   ^
    [javac] Note: Some input files use or override a deprecated API.

==
-1 for this fix.

Regards
Peter



Am 14.05.2008 um 09:17 schrieb [EMAIL PROTECTED]:

Author: markt
Date: Wed May 14 00:17:46 2008
New Revision: 656124

URL: http://svn.apache.org/viewvc?rev=656124&view=rev
Log:
Improve logging messages associated with previous commit in  
response to Filip's veto

Modified:
    tomcat/trunk/java/org/apache/tomcat/util/net/jsse/ 
JSSESocketFactory.java

Modified: tomcat/trunk/java/org/apache/tomcat/util/net/jsse/ 
JSSESocketFactory.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/ 
tomcat/util/net/jsse/JSSESocketFactory.java? 
rev=656124&r1=656123&r2=656124&view=diff
====================================================================== 
========
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/ 
JSSESocketFactory.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/ 
JSSESocketFactory.java Wed May 14 00:17:46 2008
@@ -322,17 +322,17 @@
             ks.load(istream, pass.toCharArray());
         } catch (FileNotFoundException fnfe) {
             log.error(sm.getString("jsse.keystore_load_failed",  
type, path,
-                    fnfe.getMessage()));
+                    fnfe.getMessage()), fnfe);
             throw fnfe;
         } catch (IOException ioe) {
             log.error(sm.getString("jsse.keystore_load_failed",  
type, path,
-                    ioe.getMessage()));
+                    ioe.getMessage()), ioe);
             throw ioe;
         } catch(Exception ex) {
             String msg = sm.getString("jsse.keystore_load_failed",  
type, path,
                     ex.getMessage());
-            log.error(msg);
-            throw new IOException(msg);
+            log.error(msg, ex);
+            throw new IOException(msg, ex);
         } finally {
             if (istream != null) {
                 try {



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]