> > Speaking of deps - I'm completely confused by tomcat-dbcp.jar - it > > seems to break the build ( 'download' ) with JDK1.6, yet I can't find > > > > that's because DBCP implements interfaces, and only implements the > java.sql/javax.sql up to JDK 1.5. > > > any usage in the code - and just removing it doesn't seem to hurt in > > any way. > > it's being used, removing it would prolly upset some users, as the DBCP > is the core for the tomcat connection pooling.
I did a grep - couldn't find any direct dep in the code, and removing it from the 'download' and the copy in 'deploy' just worked. There is only one ref in Constants, which is loaded with Class.forName() by the naming code. The dbcp build file actually handles jdk1.5/1.6 changes by doing some 'replace'. Our build.download just download theirs, replaces the package name and adds some more stuff. I understand people using JDBC authenticator would miss the connection pooling - but maybe they could download it separately ? Would't be easier to just download the 'official' version ? I'm also curious, assuming JDK1.5 is used to compile - would the tomcat distro work in JDK1.6 if dbcp is compiled with 1.5 ? In any case - it kind of sucks to not be able to build following the instructions ( ant download, ant ) - I didn't find any ref that JDK1.6 is not supported for build. Costin > > > Am I missing something - the jar name is referenced if few > > places, and there is a class name in Constants. I assume some JDBC > > connector stuff would not work so well unless someone install the > > package. > > > > > Costin > > > > On 3/20/08, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote: > > > >> when the commons-logging jar files got updated, they also got renamed, > >> we missed a few spots, > >> > >> some files in bin and conf still reference the old name, like > >> catalina.policy > >> // These permissions apply to the commons-logging API > >> grant codeBase "file:${catalina.home}/bin/commons-logging-api.jar" { > >> permission java.security.AllPermission; > >> }; > >> > >> > >> Filip > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]