Author: remm
Date: Mon Mar 3 17:05:51 2008
New Revision: 633342
URL: http://svn.apache.org/viewvc?rev=633342&view=rev
Log:
- Vote (the newer code does look nicer to me, in particular removing that read
method as well as a lot of
redundant code).
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=633342&r1=633341&r2=633342&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Mar 3 17:05:51 2008
@@ -129,3 +129,20 @@
-1: markt This patch removes a method from a public API. With that issue
fixed
I would vote -0 until I can look at this further as explained in
http://marc.info/?l=tomcat-dev&m=120457882215329&w=2
+ -0: remm The newer code looks cleaner to me, so I propose this patch
(bb.getLength() is equal to the
+ value used as the result of available in the other proposed patch,
and thez are thus using
+ the same limit for reading data):
+ Index: java/org/apache/catalina/connector/InputBuffer.java
+===================================================================
+--- java/org/apache/catalina/connector/InputBuffer.java (revision
633279)
++++ java/org/apache/catalina/connector/InputBuffer.java (working copy)
+@@ -355,7 +355,7 @@
+ }
+
+ state = CHAR_STATE;
+- conv.convert(bb, cb, len);
++ conv.convert(bb, cb, bb.getLength());
+ bb.setOffset(bb.getEnd());
+
+ return cb.getLength();
+
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
