OK, I've finally found some time to update the patch on http://issues.apache.org/bugzilla/show_bug.cgi?id=35297 I didn't use preproc directives, since the duplication of code in write() would have been pretty nasty. All the chunked encoding code is out of the way behind the enable_chunked_encoding flag though, so it should be fairly sane. There are some minor refactorings of the codepaths for standard responses in start_response and write, but I think they're reasonable. I've tested on IIS 5.1 and 6.0 with chunked encoding enabled and disabled with a mixed content web application (some static and dynamic content served by Tomcat) and all looks fine. I'm a spot confused about existing trunk behaviour for notification flags, so I left in my check to disable SF_NOTIFY_AUTH_COMPLETE on IIS 5.1 (since it's broken for WebDAV requests). I'm fairly neutral on that though, so feel free to veto that part of the patch. cheers tim
_____ From: Mladen Turk [mailto:[EMAIL PROTECTED] Sent: Friday, 4 January 2008 1:03 a.m. To: Tomcat Developers List Subject: Re: [ANN] Apache Tomcat JK 1.2.26 Web Server Connector released Tim Whittington wrote: > Binary builds of 1.2.26 for various platforms are available now from > http://sourceforge.net/projects/timsjk/ > These include builds of a patched IIS 5/6 ISAPI Redirector that support > HTTP 1.1 chunked encoding (and thus keep-alives on dynamic content). > Hi Tim, Can you create a patch against trunk, but with one slight ;) change to your code, and that is to #ifdef all the chunked code (at least relevant) out by some preproc directive like JK_IIS_CHUNKED so: #ifdef JK_IIS_CHUNKED // any change made to the part of the code. #endif You don't need to rule out all the stuff, but only one that are affecting current defaults. The other solution is to have some global flag (configurable) that will allow with a single directive to switch out all the chunked logic with defaults to be as is. Can you do that? I'd prefer the second option if possible, unless something needs to be changed before actually reading the configuration. Regards, Mladen --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
