Re: svn commit: r599767 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

[Peter Rossbach]

I think the change is very good. Older Connection are close first!
Peter


Am 30.11.2007 um 12:56 schrieb Mladen Turk:

[EMAIL PROTECTED] wrote:

Author: rjung
Date: Fri Nov 30 02:26:42 2007
New Revision: 599767
URL: http://svn.apache.org/viewvc?rev=599767&view=rev
Log:
Complete half-baked r599743. Care about signedness
and apply reverse order to the relevant loop to.
Modified:
    tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/ native/common/jk_ajp_common.c? rev=599767&r1=599766&r2=599767&view=diff ===================================================================== ========= --- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original) +++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Fri Nov 30 02:26:42 2007

@@ -2607,14 +2607,15 @@
         }
         JK_ENTER_CS(&aw->cs, rc);
         if (rc) {
-            unsigned int i, n = 0, cnt = 0;
+            unsigned int n = 0, cnt = 0;
+            int i;
             /* Count open slots */
-            for (i = aw->ep_cache_sz - 1; i >= 0; i--) {
+            for (i = (int)aw->ep_cache_sz - 1; i >= 0; i--) {

Cool, much better. It removes the endless loop after all
cause unsigned is always higher or equal to zero :)

However not sure it makes any difference, bit it's as closest
as we can get to the LIFO.

Cheers,
Mladen

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]