[EMAIL PROTECTED] wrote:
Author: rjung
Date: Tue Nov 20 09:29:26 2007
New Revision: 596747

URL: http://svn.apache.org/viewvc?rev=596747&view=rev
Log:
Add comments to explain timestamp formatting for sub seconds resolution.

Furthermore increased the accepted format length a bit.
Before we accepted JK_TIME_MAX_SIZE=64 bytes after replacing
the first subsecond format character, now we accept the same size
before replacing the formatting character.

Modified:
    tomcat/connectors/trunk/jk/native/common/jk_util.c


Hmm, you still have

const char * log_fmt_subsec
...
char *fmt = malloc( ...)
...
l->log_fmt_subsec = fmt;
...
free(l->log_fmt_subsec)

That's not good.

Why don't you declare
char log_fmt_subsec[SOME_MAX_SIZE] instead having it as const char* ?

Regards,
Mladen

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to