Re: Call stopAwait at StandardServer.stop

[Remy Maucherat]

Peter Rossbach wrote:
can we please fix it:
    public void stop() throws LifecycleException {

        // Validate and update our current component state
        if (!started)
            return;

        // Notify our interested LifecycleListeners
        lifecycle.fireLifecycleEvent(BEFORE_STOP_EVENT, null);

        lifecycle.fireLifecycleEvent(STOP_EVENT, null);
        started = false;

        // Stop our defined Services
        for (int i = 0; i < services.length; i++) {
            if (services[i] instanceof Lifecycle)
                ((Lifecycle) services[i]).stop();
        }
    // ====== FIX BEGIN
    if(port == -1)
        stopAwait() ;
       // ====== END
        // Notify our interested LifecycleListeners
        lifecycle.fireLifecycleEvent(AFTER_STOP_EVENT, null);

    }

I think we can also backport it to Tomcat 5.5 trunk

I was not aware of this feature. The change is ok, but I think the sleep 
time of the thread should also be reduced when the port is -1.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]