On Thu, Nov 5, 2026 at 8:02 PM Mark Thomas via dev <[email protected]> wrote: > > On 05/11/2026 18:28, remm.apache.org via dev wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > rmaucher pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/main by this push: > > new 4412d23cc7 Drop this as it can lead to issues (reflection and so > > on) > > 4412d23cc7 is described below > > > > commit 4412d23cc7203e5c93a3489aaec02e46fbe6eaf1 > > Author: remm <[email protected]> > > AuthorDate: Thu Nov 5 19:28:38 2026 +0100 > > > > Drop this as it can lead to issues (reflection and so on) > > --- > > res/checkstyle/test-checkstyle.xml | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/res/checkstyle/test-checkstyle.xml > > b/res/checkstyle/test-checkstyle.xml > > index a1ccab1689..c9884730c3 100644 > > --- a/res/checkstyle/test-checkstyle.xml > > +++ b/res/checkstyle/test-checkstyle.xml > > @@ -92,7 +92,6 @@ > > > > <!-- Modifiers --> > > <module name="ModifierOrder"/> > > - <module name="RedundantModifier"/> > > Really? > > If the modifier is redundant it shouldn't matter if it is present or > not. Can you provide an example?
Yes, I had it happen on a non public subclass or sub interface where you cannot access the methods because checkstyle does not allow you to make them public (I think the solution is to make it explicitly public). Also I didn't understand the purpose of these endless checkstyle/warnings/errors on tests. It seems from your message that you would prefer to keep this, so I'll revert it and fix the few checkstyle issues. Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
