vgosain-psg opened a new pull request, #1146: URL: https://github.com/apache/tomcat/pull/1146
## Summary - Introduces `SmokeTest` category marker interface and `SmokeSuite` as a compile-checked alternative to the property file-based smoke profile - Annotates all 57 smoke test classes with `@Category(SmokeTest.class)` so the tag lives next to the code rather than in a separate properties file - Adds `ant test-smoke-category` target to run the suite via JUnit's Categories runner - Updates `test-profiles.properties.default` to replace the deleted `TestHostConfigAutomaticDeploymentA/B/C` with their refactored successors (Dir, War, Xml) - Updates `BUILDING.txt` with profile usage instructions and an explanation of the category-based approach The existing property-based smoke profile is left intact — this is a proof of concept running alongside it, not a replacement. The intent is to gather feedback before deciding whether to extend categories to other profiles and retire the properties file mechanism. Addresses: JWS-4412 ## Test plan - [ ] `ant test-compile` passes cleanly (verified locally — 0 errors) - [ ] `ant test -Dtest.profile=smoke` still works as before (existing mechanism unchanged) - [ ] `ant test-smoke-category` runs the new category-based suite and produces equivalent results - [ ] Renaming or deleting an annotated class causes a compile error in `SmokeSuite.java` (the key safety property) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
