markt-asf commented on code in PR #1102:
URL: https://github.com/apache/tomcat/pull/1102#discussion_r4362266716
##########
modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ProxyConnection.java:
##########
@@ -137,6 +137,23 @@ public Object invoke(Object proxy, Method method, Object[]
args) throws Throwabl
this.connection = null;
pool.returnConnection(poolc);
return null;
+ } else if (compare(ABORT_VAL,method)) {
+ if (connection==null)
+ {
+ return null; //noop for already closed.
+ }
+ PooledConnection poolc = this.connection;
+ this.connection = null;
+ try {
+ method.invoke(poolc.getConnection(),args);
Review Comment:
poolc.getConnection() could return null. Worth checking before calling
invoke()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
