On 03/06/2026 08:31, Rémy Maucherat wrote:
Hi,
I'm through the first full code review.
Excellent. I'm around a day behind you reviewing the changes.
Some notes:
- I did not look much at the issues for some components. This includes
clustering, bcel, fileupload, dbcp, pool, some websockets.
I'm less concerned about bcel, fileupload, dbcp and pool since any
issues need to be addressed in Commons for us to pick up.
- I'm now processing another full code review.
- I skipped over cosmetic and low issues the first time, and issues
for some components. I'll do things more thoroughly this time since
there's less urgency.
Ack.
As we get close to the tags we might need a short quiet period just to
give us a chance to make sure all the changes are reviewed and the tests
all pass before we tag.
In terms of tags:
- there are a couple of BZ issues I'd like to address although fixing
all open BZ issues might not be feasible with the current volume of
issues that various reviews are generating
- We'll need an updated Commons Daemon (1.6.1) as there is a packaging
issue in 1.6.0.
- Migration tool looks to be on track to be released tomorrow
- i18n sync with POEditor needs to be completed
- I have a couple of things from $dayjob I want to look at
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
