YCharanGowda commented on code in PR #962:
URL: https://github.com/apache/tomcat/pull/962#discussion_r2969461647
##########
test/org/apache/tomcat/util/buf/TestStringUtils.java:
##########
@@ -31,47 +15,65 @@ public void testNullArray() {
Assert.assertEquals("", StringUtils.join((String[]) null));
}
-
@Test
public void testNullArrayCharStringBuilder() {
StringBuilder sb = new StringBuilder();
StringUtils.join((String[]) null, ',', sb);
Assert.assertEquals("", sb.toString());
}
-
Review Comment:
ok, sir
##########
test/org/apache/tomcat/util/buf/TestStringUtils.java:
##########
@@ -31,47 +15,65 @@ public void testNullArray() {
Assert.assertEquals("", StringUtils.join((String[]) null));
}
-
@Test
public void testNullArrayCharStringBuilder() {
StringBuilder sb = new StringBuilder();
StringUtils.join((String[]) null, ',', sb);
Assert.assertEquals("", sb.toString());
}
-
@Test
public void testNullCollection() {
Assert.assertEquals("", StringUtils.join((Collection<String>) null));
}
-
Review Comment:
ok,sir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
