On 29/12/2025 06:59, 박종하 wrote:
Hello everyone,
I’m currently working on an issue that is labeled as related to Tomcat 9.
Based on that, I created a branch from the Tomcat 9.x branch, implemented
the fix, and prepared a merge into the same 9.x branch. However, I haven’t
received any review yet, and this made me wonder whether I might be
following the wrong process.
Should I instead create the fix based on the main branch and target main
for the merge, even if the issue mentions Tomcat 9? I want to make sure I’m
aligning with the project’s contribution workflow.
This is my first contribution to Tomcat, and I’m hoping to continue
contributing regularly, so I apologize if this is a basic question. I’d
really appreciate your guidance and understanding.
Thank you very much for your time.
The active branches are all pretty similar and most changes get applied
to all active branches so it doesn't really matter that much which
branch is used as the base. We can work with any of them.
Generally, changes are made to main first so there is a slight
preference for main over any of the other branches.
One thing that isn't helpful - unless explicitly asked for - is a PR per
branch.
One thing that would be helpful is fixing the link to the BZ issue in
the PR so it points to the correct issue.
If you have been following the dev@ list you will have seen that the
Tomcat committers were a little busy on some Tomcat Native issues before
the holidays and that that is likely to continue into the new year.
Because the Native release needs to be completed before there can be a
Tomcat release that uses the new functionality, the Native release has
been the priority.
Between releases PRs get looked at depending on when committers have the
time to do so but all PRs are reviewed before a release so, at the
latest, someone will be looking at your PR before the next release.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
