MegaManSec opened a new pull request, #915: URL: https://github.com/apache/tomcat/pull/915
createSSLSocketFactoryFromClassName(String) returned the field `sslSocketFactory` instead of the newly constructed instance. On first use this field is null, causing getSSLSocketFactory() to cache null and StartTLS to proceed without the administrator-supplied factory. Impact: custom truststores/hostname verification/cipher selection are silently ignored for LDAP StartTLS connections. Fix: return the constructed `(SSLSocketFactory) o` so the configured factory is applied and cached correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
