csutherl opened a new pull request, #913:
URL: https://github.com/apache/tomcat/pull/913
While I was poking around with the test categorization changes I'm working
on I noticed that some of the buildutils tests were failing. I took a pass at
adjusting the logic to pass the tests, but I've never used POEditor so
creating a PR to be safe :)
## Summary
- Fixed `formatValueImport` in buildutil Utils class to properly handle
MessageFormat quote escaping and line continuation formatting
- Removed unnecessary call to `formatValueCommon`
## Problem
7/10 buildutil tests were failing because `formatValueImport` wasn't:
1. Doubling single quotes for MessageFormat placeholders (e.g., `{0}`)
2. Adding line continuations after initial `\n` escape sequences
## Solution
Replaced the call to `formatValueCommon` with new logic to handle
import-specific formatting. All 10 tests in `TestUtils` now pass (previously 7
failures).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
