ChristopherSchultz commented on code in PR #912: URL: https://github.com/apache/tomcat/pull/912#discussion_r2470062381
########## java/org/apache/tomcat/util/net/openssl/OpenSSLCertificateVerifier.java: ########## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.tomcat.util.net.openssl; + +import java.security.cert.X509Certificate; + +import javax.net.ssl.X509TrustManager; + +import org.apache.juli.logging.Log; +import org.apache.juli.logging.LogFactory; +import org.apache.tomcat.jni.CertificateVerifier; +import org.apache.tomcat.util.res.StringManager; + +public class OpenSSLCertificateVerifier implements CertificateVerifier { + + private static final Log log = LogFactory.getLog(OpenSSLCertificateVerifier.class); + private static final StringManager sm = StringManager.getManager(OpenSSLContext.class); + + private final X509TrustManager x509TrustManager; + + public OpenSSLCertificateVerifier(X509TrustManager x509TrustManager) { + this.x509TrustManager = x509TrustManager; + } + + @Override + public boolean verify(long ssl, byte[][] chain, String auth) { + X509Certificate[] peerCerts = certificates(chain); Review Comment: If we don't expect the `x509TrustManager`'s list of certificates to change, we could call certificates() once and save repeatedly generating a temporary `X509Certificate[]`, etc. Is it a reasonable assumption that the TrustManager isn't being modified once the `OpenSSLCertificateVerifier` is being constructed? The previous code was always up-to-date with whatever the TrustManager contained, but that could have just been accidental. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
