This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit f567262bb9ad859ed75e69d2361568f3cfcad158
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Thu Sep 11 12:29:55 2025 +0100

    Use constant for MKCOL
---
 java/org/apache/coyote/ajp/Constants.java                             | 2 +-
 .../apache/catalina/servlets/TestWebdavServletOptionCollection.java   | 2 +-
 test/org/apache/catalina/servlets/TestWebdavServletOptionsFile.java   | 2 +-
 .../org/apache/catalina/servlets/TestWebdavServletOptionsUnknown.java | 2 +-
 test/org/apache/coyote/ajp/SimpleAjpClient.java                       | 4 ++--
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/java/org/apache/coyote/ajp/Constants.java 
b/java/org/apache/coyote/ajp/Constants.java
index e5ee52f64b..12b581be3d 100644
--- a/java/org/apache/coyote/ajp/Constants.java
+++ b/java/org/apache/coyote/ajp/Constants.java
@@ -107,7 +107,7 @@ public final class Constants {
 
     // Translates integer codes to names of HTTP methods
     private static final String[] methodTransArray =
-            { Method.OPTIONS, Method.GET, Method.HEAD, Method.POST, 
Method.PUT, Method.OPTIONS, Method.TRACE, Method.TRACE, Method.PROPPATCH, 
"MKCOL", "COPY",
+            { Method.OPTIONS, Method.GET, Method.HEAD, Method.POST, 
Method.PUT, Method.OPTIONS, Method.TRACE, Method.TRACE, Method.PROPPATCH, 
Method.MKCOL, "COPY",
                     "MOVE", "LOCK", "UNLOCK", "ACL", "REPORT", 
"VERSION-CONTROL", "CHECKIN", "CHECKOUT", "UNCHECKOUT",
                     "SEARCH", "MKWORKSPACE", "UPDATE", "LABEL", "MERGE", 
"BASELINE-CONTROL", "MKACTIVITY" };
 
diff --git 
a/test/org/apache/catalina/servlets/TestWebdavServletOptionCollection.java 
b/test/org/apache/catalina/servlets/TestWebdavServletOptionCollection.java
index 58ba7a3a53..cfdf82e857 100644
--- a/test/org/apache/catalina/servlets/TestWebdavServletOptionCollection.java
+++ b/test/org/apache/catalina/servlets/TestWebdavServletOptionCollection.java
@@ -38,7 +38,7 @@ public class TestWebdavServletOptionCollection extends 
ServletOptionsBaseTest {
     @Parameters
     public static Collection<Object[]> inputs() {
         String[] methods = new String[] { Method.GET, Method.POST, 
Method.HEAD, Method.TRACE, Method.PUT, Method.DELETE,
-                "MKCOL", "LOCK", "UNLOCK", "COPY", "MOVE", Method.PROPFIND, 
Method.PROPPATCH };
+                Method.MKCOL, "LOCK", "UNLOCK", "COPY", "MOVE", 
Method.PROPFIND, Method.PROPPATCH };
 
         List<Object[]> result = new ArrayList<>();
 
diff --git 
a/test/org/apache/catalina/servlets/TestWebdavServletOptionsFile.java 
b/test/org/apache/catalina/servlets/TestWebdavServletOptionsFile.java
index 1c047a247a..2dce706ff5 100644
--- a/test/org/apache/catalina/servlets/TestWebdavServletOptionsFile.java
+++ b/test/org/apache/catalina/servlets/TestWebdavServletOptionsFile.java
@@ -38,7 +38,7 @@ public class TestWebdavServletOptionsFile extends 
ServletOptionsBaseTest {
     @Parameters
     public static Collection<Object[]> inputs() {
         String[] methods = new String[] { Method.GET, Method.POST, 
Method.HEAD, Method.TRACE, Method.PUT, Method.DELETE,
-                "MKCOL", "LOCK", "UNLOCK", "COPY", "MOVE", Method.PROPFIND, 
Method.PROPPATCH };
+                Method.MKCOL, "LOCK", "UNLOCK", "COPY", "MOVE", 
Method.PROPFIND, Method.PROPPATCH };
 
         List<Object[]> result = new ArrayList<>();
 
diff --git 
a/test/org/apache/catalina/servlets/TestWebdavServletOptionsUnknown.java 
b/test/org/apache/catalina/servlets/TestWebdavServletOptionsUnknown.java
index b5f0dc5d46..322bbbaabd 100644
--- a/test/org/apache/catalina/servlets/TestWebdavServletOptionsUnknown.java
+++ b/test/org/apache/catalina/servlets/TestWebdavServletOptionsUnknown.java
@@ -38,7 +38,7 @@ public class TestWebdavServletOptionsUnknown extends 
ServletOptionsBaseTest {
     @Parameters
     public static Collection<Object[]> inputs() {
         String[] methods = new String[] { Method.GET, Method.POST, 
Method.HEAD, Method.TRACE, Method.PUT, Method.DELETE,
-                "MKCOL", "LOCK", "UNLOCK", "COPY", "MOVE", Method.PROPFIND, 
Method.PROPPATCH };
+                Method.MKCOL, "LOCK", "UNLOCK", "COPY", "MOVE", 
Method.PROPFIND, Method.PROPPATCH };
 
         List<Object[]> result = new ArrayList<>();
 
diff --git a/test/org/apache/coyote/ajp/SimpleAjpClient.java 
b/test/org/apache/coyote/ajp/SimpleAjpClient.java
index 6a3c43fa56..040e5be9d8 100644
--- a/test/org/apache/coyote/ajp/SimpleAjpClient.java
+++ b/test/org/apache/coyote/ajp/SimpleAjpClient.java
@@ -103,7 +103,7 @@ public class SimpleAjpClient {
             case Method.PROPPATCH:
                 this.method = 9;
                 break;
-            case "MKCOL":
+            case Method.MKCOL:
                 this.method = 10;
                 break;
             case "COPY":
@@ -183,7 +183,7 @@ public class SimpleAjpClient {
             case 9:
                 return Method.PROPPATCH;
             case 10:
-                return "MKCOL";
+                return Method.MKCOL;
             case 11:
                 return "COPY";
             case 12:


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to