On 10/09/2025 14:32, Dimitris Soumis wrote:
On Wed, Sep 10, 2025 at 4:26 PM <[email protected]> wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 5262f92e10 Fix IDE warnings
5262f92e10 is described below
commit 5262f92e100b397117bc4b65b64d7caa67501d44
Author: Mark Thomas <[email protected]>
AuthorDate: Wed Sep 10 14:16:43 2025 +0100
Fix IDE warnings
---
test/org/apache/catalina/manager/TestManagerWebapp.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/catalina/manager/TestManagerWebapp.java
b/test/org/apache/catalina/manager/TestManagerWebapp.java
index e14d8008b4..06a615dacf 100644
--- a/test/org/apache/catalina/manager/TestManagerWebapp.java
+++ b/test/org/apache/catalina/manager/TestManagerWebapp.java
@@ -503,7 +503,9 @@ public class TestManagerWebapp extends TomcatBaseTest {
tomcat.stop();
}
- /**
+
+
+ /*
* Test case for <a href="
https://bz.apache.org/bugzilla/show_bug.cgi?id=57700";>Bug 57700</a>.
*/
@Test
@@ -534,7 +536,7 @@ public class TestManagerWebapp extends TomcatBaseTest {
Assert.assertTrue(appRoot.mkdirs() && appRoot.isDirectory());
addDeleteOnTearDown(appRoot);
- try (TomcatBaseTest.ContainerInjector ignored =
+ try (@SuppressWarnings("unused") TomcatBaseTest.ContainerInjector
ignored =
TomcatBaseTest.ContainerInjector.inject(ctx.getParent(),
c -> c.getPath().equals("/bug57700"),
c -> {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Hmm no warnings were raised in Intellij. Were those raised in Eclipse IDE?
Yes. No Javadoc for exception (so switch to non-Javadoc - we don't need
Javadoc for tests) and an unused variable.
Mark>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
