This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 4d5863b469 Remove NIO2 issues since NIO2 has been removed
4d5863b469 is described below
commit 4d5863b469e86216af85b6a85abc1c6e34467a34
Author: Mark Thomas <[email protected]>
AuthorDate: Sat Aug 30 17:19:47 2025 +0100
Remove NIO2 issues since NIO2 has been removed
---
res/spotbugs/filter-false-positives.xml | 31 -------------------------------
1 file changed, 31 deletions(-)
diff --git a/res/spotbugs/filter-false-positives.xml
b/res/spotbugs/filter-false-positives.xml
index 47a8c0b6cf..1acaed066a 100644
--- a/res/spotbugs/filter-false-positives.xml
+++ b/res/spotbugs/filter-false-positives.xml
@@ -1593,7 +1593,6 @@
<!-- Object is only ever set to null, sync therefore is still valid -->
<Or>
<Class name="org.apache.tomcat.util.net.NioEndpoint$SocketProcessor"/>
- <Class name="org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor"/>
</Or>
<Method name="run"/>
<Bug code="ML"/>
@@ -1604,30 +1603,6 @@
<Method name="processKey"/>
<Bug pattern="NO_NOTIFY_NOT_NOTIFYALL" />
</Match>
- <Match>
- <!-- Single condition so no need for wait to be in loop -->
- <Class name="org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper"/>
- <Or>
- <Method name="read"/>
- <Method name="write"/>
- </Or>
- <Bug pattern="WA_NOT_IN_LOOP" />
- </Match>
- <Match>
- <!-- Single wait so no need for notifyAll() -->
- <Class
name="org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$VectoredIOCompletionHandler"/>
- <Or>
- <Method name="completed"/>
- <Method name="failed"/>
- </Or>
- <Bug pattern="NO_NOTIFY_NOT_NOTIFYALL " />
- </Match>
- <Match>
- <!-- NPE should never happen but it is caught as a precaution -->
- <Class name="org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor" />
- <Method name="doRun" />
- <Bug pattern="DCN_NULLPOINTER_EXCEPTION" />
- </Match>
<Match>
<Class name="org.apache.tomcat.util.net.SecureNioChannel"/>
<Method name="rehandshake"/>
@@ -1639,12 +1614,6 @@
<Method name="processSNI"/>
<Bug code="SF" />
</Match>
- <Match>
- <!-- Fall-through expected -->
- <Class name="org.apache.tomcat.util.net.SecureNio2Channel" />
- <Method name="processSNI"/>
- <Bug code="SF" />
- </Match>
<Match>
<!-- Single condition so notify is fine -->
<Class
name="org.apache.tomcat.util.net.SocketWrapperBase$VectoredIOCompletionHandler"
/>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
