This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 2860e92d54 Review trace level logging
2860e92d54 is described below
commit 2860e92d54df4f4ddbf0eaedd6d89b133390dd1e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Aug 19 17:29:55 2025 +0100
Review trace level logging
---
java/org/apache/catalina/realm/JNDIRealm.java | 2 +-
java/org/apache/catalina/tribes/Channel.java | 2 +-
java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java | 3 ++-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/java/org/apache/catalina/realm/JNDIRealm.java
b/java/org/apache/catalina/realm/JNDIRealm.java
index e946474566..297f1c99b5 100644
--- a/java/org/apache/catalina/realm/JNDIRealm.java
+++ b/java/org/apache/catalina/realm/JNDIRealm.java
@@ -1848,7 +1848,7 @@ public class JNDIRealm extends RealmBase {
validated = true;
} catch (AuthenticationException e) {
if (containerLog.isTraceEnabled()) {
- containerLog.trace(" bind attempt failed");
+ containerLog.trace(" bind attempt failed", e);
}
} finally {
// Restore GSSAPI SASL if previously configured
diff --git a/java/org/apache/catalina/tribes/Channel.java
b/java/org/apache/catalina/tribes/Channel.java
index 3afc3b527c..dad7c18c83 100644
--- a/java/org/apache/catalina/tribes/Channel.java
+++ b/java/org/apache/catalina/tribes/Channel.java
@@ -516,7 +516,7 @@ public interface Channel {
} catch (NumberFormatException nfe) {
final Log log = LogFactory.getLog(Channel.class);
log.trace(String.format("Failed to parse [%s] as integer,
channelSendOptions possibly set by name(s)",
- input));
+ input), nfe);
}
String[] options = input.split("\\s*,\\s*");
diff --git
a/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
b/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
index f73952927c..e39cd38485 100644
--- a/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
+++ b/java/org/apache/catalina/tribes/transport/nio/NioReplicationTask.java
@@ -214,7 +214,8 @@ public class NioReplicationTask extends AbstractRxTask {
try {
Logs.MESSAGES.trace("NioReplicationThread - Received
msg:" + new UniqueId(msg.getUniqueId()) +
" at " + new
java.sql.Timestamp(System.currentTimeMillis()));
- } catch (Throwable t) {
+ } catch (Throwable ignore) {
+ // Ignore
}
}
// process the message
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
