On 19/08/2025 17:43, Mark Thomas wrote:
On 19/08/2025 17:38, Christopher Schultz wrote:
> On 8/19/25 11:22 AM, Mark Thomas wrote:
<snip/>
I've currently got it working on
"catch (Exception <not e>)" to "catch (Exception e)"
although I want to look at the diff for that one to see how big it is
before deciding whether or not it is worth the noise to commit.
Depending on how that goes, I might get it to do
"catch (IOException <not ioe>)" to "catch (IOException ioe)"
After that ... ?
There is a question of how far to take this and the commits already
made to main might be enough. There is a trade off to make between
consistent code being easier to read and noisy history making it
harder to review changes over time.
Thoughts?
I couldn't care less about noisy history. More readable means more
maintainable.
Ack
P.S. I will be back-porting the logging changes but I might leave it
until tomorrow in case folks object
+1
I would wait as well. You may a as well make a bunch of changes to
main, let anyone give feedback over a day or so, and then back-port
everything to the other branches.
I'll commit what I have so far and I might have some more tomorrow.
Back-ports likely to wait until Thursday.
I think I am done with the logging changes for now. Back-ports to follow
- probably tomorrow.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
