On 18/08/2025 14:59, Christopher Schultz wrote:
Mark,
On 8/18/25 4:49 AM, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new ba5e6beffa Simplify
ba5e6beffa is described below
commit ba5e6beffa673c35f404e77536c348c33fef6c96
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Aug 18 09:43:36 2025 +0100
Simplify
---
java/org/apache/tomcat/util/net/Acceptor.java | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/Acceptor.java b/java/org/
apache/tomcat/util/net/Acceptor.java
index 1d8e93acc0..8e786eb719 100644
--- a/java/org/apache/tomcat/util/net/Acceptor.java
+++ b/java/org/apache/tomcat/util/net/Acceptor.java
@@ -152,8 +152,7 @@ public class Acceptor<U> implements Runnable {
}
} catch (Throwable t) {
ExceptionUtils.handleThrowable(t);
- String msg = sm.getString("endpoint.accept.fail");
- log.error(msg, t);
+ log.error(sm.getString("endpoint.accept.fail"), t);
}
}
} finally {
I see more instances of this in the source. I was tempted to make this
change myself but wasn't sure if it would be considered "churn".
I'd view anything that simplified the source as a good thing.
There are a few instances where this is appropriate because msg is used
more than once but happy to see any remaining single uses simplified.
Unless there are any objections, I'll make similar changes where I find
them.
None here.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
