Mark,
On 8/18/25 8:48 AM, ma...@apache.org wrote:
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 4d800c6d62 Formatting - fix line length
4d800c6d62 is described below
commit 4d800c6d620a9fa000d073e01bb2e221286e95ef
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Mon Aug 18 13:47:58 2025 +0100
Formatting - fix line length
Is this something we should add to checkstyle?
I tried a simple "max line check" and it complained about every
properties file we have. I'm not very familiar with checkstyle, but it
would seem to be "easy" to add such a check assuming we could limit it
to .java files.
-chris
---
java/org/apache/catalina/connector/Request.java | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/catalina/connector/Request.java
b/java/org/apache/catalina/connector/Request.java
index 042e199659..7f7b393013 100644
--- a/java/org/apache/catalina/connector/Request.java
+++ b/java/org/apache/catalina/connector/Request.java
@@ -953,8 +953,8 @@ public class Request implements HttpServletRequest {
* {@inheritDoc}
* <p>
* The attribute names returned will only be those for the attributes set
via {@link #setAttribute(String, Object)}.
- * Tomcat internal attributes will not be included even though they are
accessible via {@link #getAttribute(String)}.
- * The Tomcat internal attributes include:
+ * Tomcat internal attributes will not be included even though they are
accessible via
+ * {@link #getAttribute(String)}. The Tomcat internal attributes include:
* <ul>
* <li>{@link Globals#DISPATCHER_TYPE_ATTR}</li>
* <li>{@link Globals#DISPATCHER_REQUEST_PATH_ATTR}</li>
@@ -2336,7 +2336,8 @@ public class Request implements HttpServletRequest {
if (partsParseException != null) {
Context context = getContext();
if (context != null && context.getLogger().isDebugEnabled()) {
-
context.getLogger().debug(sm.getString("coyoteRequest.partsParseException",
partsParseException.getMessage()));
+ context.getLogger()
+
.debug(sm.getString("coyoteRequest.partsParseException",
partsParseException.getMessage()));
}
switch (partsParseException) {
case IOException ioException -> throw ioException;
@@ -2738,7 +2739,8 @@ public class Request implements HttpServletRequest {
if (parametersParseException != null) {
Context context = getContext();
if (context != null && context.getLogger().isDebugEnabled()) {
-
context.getLogger().debug(sm.getString("coyoteRequest.parametersParseException",
parametersParseException.getMessage()));
+ context.getLogger().debug(
+ sm.getString("coyoteRequest.parametersParseException",
parametersParseException.getMessage()));
}
throw parametersParseException;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
