ChristopherSchultz commented on PR #882: URL: https://github.com/apache/tomcat/pull/882#issuecomment-3197053936
I'm not sure I see a change. In `remove()`, `File.exists` is still called before obtaining the lock. I think you should obtain the lock first. If you disagree, that's fine, but please provide a justification. Also, please don't force-push and overwrite the commits. It's fine to have a PR with 10 commits. It makes is much easier to review the follow-up changes you've requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
